[Piuparts-devel] pull request - five-holger

[Dave Steele]

2dea977 dwke - Create the Section dir if not present.




commit 2dea9776ef1ea696b9c8520a9d426923aca2ceb7
Author: David Steele <dsteele at gmail.com>
Date:   Wed May 22 19:15:20 2013 -0400

    dwke - Create the Section dir if not present.

    detect_well_known_errors() was crashing during the daily run on days
    when a section was added (due to a return with the wrong number of
    arguments).



Most recently:

Cron Daemon root at pejacevic.debian.org
Wed May 22 00:30:47 UTC 2013

Previous message: [Piuparts-reports] report_newly_bugged_packages
Next message: [Piuparts-reports] piuparts-report
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

________________________________

Traceback (most recent call last):
  File "/srv/piuparts.debian.org/share/piuparts/master/detect_well_known_errors",
line 557, in <module>
    detect_well_known_errors( conf, problem_list, False, False )
  File "/srv/piuparts.debian.org/share/piuparts/master/detect_well_known_errors",
line 521, in detect_well_known_errors
    recheck, recheck_failed )
TypeError: 'NoneType' object is not iterable

diff --git a/master-bin/detect_well_known_errors.py
b/master-bin/detect_well_known_erro
index bc91540..6373d48 100755
--- a/master-bin/detect_well_known_errors.py
+++ b/master-bin/detect_well_known_errors.py
@@ -465,10 +465,7 @@ def process_section( section, config, problem_list,
     sectiondir = os.path.join( config['master-directory'], section )
     workdirs = [ os.path.join(sectiondir,x) for x in KPR_DIRS ]

-    if not os.access( sectiondir, os.F_OK ):
-        return
-
-    [os.mkdir(x) for x in workdirs if not os.path.exists(x)]
+    [os.mkdir(x) for x in [sectiondir] + workdirs if not os.path.exists(x)]

     (logdict, kprdict, bugdict) = [ get_file_dict(workdirs, x ) \
             for x in [LOG_EXT, KPR_EXT, BUG_EXT] ]