[Piuparts-devel] NACK! Re: pull request - five-holger

[Andreas Beckmann]

On 2013-05-23 01:53, Dave Steele wrote:
> 2dea977 dwke - Create the Section dir if not present.

> -    [os.mkdir(x) for x in workdirs if not os.path.exists(x)]
> +    [os.mkdir(x) for x in [sectiondir] + workdirs if not os.path.exists(x)]

NACK!

There is no guarantee that sectiondir is one-level, we explicitly
support sections like "sid/main".

Use

  [os.makedirs(x) for x in workdirs if not os.path.exists(x)]

but better: skip section if sectiondir does not exist - there are no
logs, so nothing to do anyway.


Andreas