[Piuparts-devel] Dave's submission branch

[Holger Levsen]

Hi,

I've rebased Dave's submission branch and pushed to alioth, and now I have 
some questions/comments, inline after the commit message, prepended with a 
"holger":


$ git log develop..submission
commit eda7df63daaf58ea2f3b3ed951a4f80b4514fd52
Author: David Steele <dsteele at gmail.com>
Date:   Wed May 28 20:54:10 2014 -0400

    piuparts-report.py: Link to counts.txt
    
    Below the chart on each section page.

holger: fine

commit 90984940b1e5f03db18c6aadd61abb2e95b53e8c
Author: David Steele <dsteele at gmail.com>
Date:   Wed May 28 20:34:19 2014 -0400

    piuparts-report.py: Restore counts.txt to web
    
    Commit 70fe80693 moved the counts.txt file, which drives the section test
    result chart, from the web section directory to the master section 
directory,
    making it no longer visible from a web view. This change restores a copy 
of
    the counts.txt file to its original location, in the web section 
directory.

holger: fine

commit 60de3e74fee3056e1a95635313aeef616e244c75
Author: David Steele <dsteele at gmail.com>
Date:   Thu May 29 06:55:16 2014 -0400

    Remove stable dist results from p.d.o summary
    
    Select this commit for further de-chaffing of the JSON summary.
    
    Remaining sections are currently:
    
    experimental
    jessie
    sid
    sid2experimental
    sid-nodoc
    testing2sid

holger: shouldnt reporting-sections not rather  be called json-reporting-
sections? are does this also disable generating the web reports for these 
sections?

commit 6b00f536ca817cd5f35e90f7f8c881297c75c6f8
Author: David Steele <dsteele at gmail.com>
Date:   Thu May 29 06:50:06 2014 -0400

    Remove oldstable and older from p.d.o summary
    
    There is a desire in the DDPO integration to add value to the Piuparts
    column by showing more detail in the failures, and to winnow out chaff
    in the reporting.
    
    The details on how to do this are not fully developed. In the
    meantime, as a first, interim, step, configure p.d.o to remove summary
    reporting for section tests involving oldstable and older.

holger: shouldnt reporting-sections not rather  be called json-reporting-
sections? are does this also disable generating the web reports for these 
sections?

commit 64615858e8a8021e593a22649fac0656e116fb5b
Author: David Steele <dsteele at gmail.com>
Date:   Sun Apr 27 14:34:37 2014 -0400

    piuparts-report.py: Refactor global summary
    
    Factor out the section sorting logic to from generate_global_summary()
    to another function, sections_by_precedence().

holger: this has gone missing
-    if os.path.isfile(summary_path):
-        os.unlink(summary_path)

?

commit 71331b6431efd54fb47c4e4414526d77d2462559
Author: David Steele <dsteele at gmail.com>
Date:   Wed Apr 30 15:17:52 2014 -0400

    piuparts-report.py: De-indent global summary func
    
    Remove four spaces of indent from the body of
    generate_global_summary().

holger: fine


cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20140621/aa53bc62/attachment.sig>