[Piuparts-devel] Bug#746621: DDPO: Integrate Piuparts (w/ patches)

[Holger Levsen]

Hi,

On Freitag, 2. Mai 2014, Holger Levsen wrote:
> (As a side comment: I hardcoded this (choice of protocal) as a.) I'm lazy
> b.) everybody should use https c.) it was a one byte change as opposed to
> 200 or so for doing it properly. Patches to fix this properly are much
> welcome as I now feel bad for pushing such a hack. I'll reply to this to
> the piuparts devel list only...)

source_summary_url() only get's called once, as

                    url = source_summary_url(
                              web_host, self._doc_root,
                              self._config.section, srcpkg)

and I wonder if it wouldnt be better to use self._web_host and 
self._web_protocol here instead...

Sadly I'm too busy with other crap to think properly think about this now, so 
here I am asking for comments/patches ;-)


cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20140502/9a2622b3/attachment.sig>