[Piuparts-devel] Bug#746621: DDPO: Integrate Piuparts (w/ patches)

[Dave Steele]

On Fri, May 2, 2014 at 6:35 AM, Holger Levsen <holger at layer-acht.org> wrote:
> Hi,
>
> On Freitag, 2. Mai 2014, Holger Levsen wrote:
>> (As a side comment: I hardcoded this (choice of protocal) as a.) I'm lazy
>> b.) everybody should use https c.) it was a one byte change as opposed to
>> 200 or so for doing it properly. Patches to fix this properly are much
>> welcome as I now feel bad for pushing such a hack. I'll reply to this to
>> the piuparts devel list only...)

The one byte change is proper enough, IMO. I'd prefer the more general
'http', and take advantage of redirection, but your's is the simple
fix to enforce HTTPS, given the current popcon environment.

> I wonder if it wouldnt be better to use self._web_host and
> self._web_protocol here instead...

As you say, it is only called once. Better to avoid two more member
variables just for that?

-- 
"Le mieux est l'ennemi du bien" - Voltaire