[Piuparts-devel] Bug#746621: DDPO: Integrate Piuparts (w/ patches)

[Holger Levsen]

Hi,

On Freitag, 2. Mai 2014, Dave Steele wrote:
> The one byte change is proper enough, IMO. I'd prefer the more general
> 'http', and take advantage of redirection, but your's is the simple

redirection takes away the privacy benefit of https, thats why I decided to 
change the links. (Hoping that the PTS will soon also default to https 
only...)

> > I wonder if it wouldnt be better to use self._web_host and
> > self._web_protocol here instead...
> As you say, it is only called once. Better to avoid two more member
> variables just for that?

well, couldnt/shouldnt web_host be turned into self.web_host instead as well? 
(I've only looked very briefly at the code...)


cheers,
	Holger


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20140502/4dab9851/attachment-0001.sig>