[Piuparts-devel] Bug#893731: Bug#893731: [piuparts] Please add docker support

[Agustin Henze]

On 03/25/18 10:41, Holger Levsen wrote:
[...]
>>>>      def create_resolv_conf(self):
>>>> +        if settings.docker_image:
>>>> +            # Do nothing, docker already takes care of this
>>>> +            return
>>>
>>> and
>>>
>>>>      def terminate_running_processes(self):
>>>> +        if settings.docker_image:
>>>> +            # docker takes care of this
>>>> +            return
>>>
>>> here I wonder: is it really cleaner to return if docker is used or
>>> wouldnt it be better to not call it in the first place?
>>
>> Maybe, I'm not totally sure, but if you feel it's better, I prefer the way you
>> feel more comfortable :). After all, it's your little creature hehe
>  
> I've now looked at the surrounding code and indeed I would like these
> checks to be moved to the calling functions. check_for_no_processes()
> and configure_chroot() already have other conditional code blocks moving
> the code from "above" there seems better indeed.
> 

Ok, back to the first approach then.

[...]
> 
> I guess we are really close to merging this now! \o/
> 

Great! Thanks to both for the review

-- 
TiN
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-docker-support-new-param-is-introduced-docker-im.patch
Type: text/x-patch
Size: 8649 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20180326/ceba9b4b/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-docker-image-param-doc-in-manpage.patch
Type: text/x-patch
Size: 1175 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20180326/ceba9b4b/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Rewrite-keep-tmpdir-doc.patch
Type: text/x-patch
Size: 1930 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20180326/ceba9b4b/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Rephrase-schroot-param-doc.patch
Type: text/x-patch
Size: 1969 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20180326/ceba9b4b/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-docker.io-as-suggested-package.patch
Type: text/x-patch
Size: 763 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20180326/ceba9b4b/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Update-debian-changelog.patch
Type: text/x-patch
Size: 994 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20180326/ceba9b4b/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20180326/ceba9b4b/attachment-0001.sig>