[Piuparts-devel] next batch of patches

Holger Levsen holger at layer-acht.org
Mon Oct 15 15:35:57 BST 2018


On Mon, Oct 15, 2018 at 02:21:27PM +0200, Andreas Beckmann wrote:
> >> b40612361 p: compute file_owners earlier
> > out of curiosity: why?
> For this vvv
 
???

> >> 7263a5194 p.conf: move --skip-logrotatefiles-test to the end-* flags
> > also slightlty wondering why
> logrotate tests run in the target distro, and it's sufficient to have a
> fixed logrotate there, enables logrotate tests on stretch->buster tests

ah, thanks!

> >> cc83d6ac1 do not reinvent nproc
> > oh, wow, thanks teaching me this one! :)
> I had stumbled upon this somewhere ... and then I saw my implementation
> of it ...
 
I also use my own similar implementation of this elsewhere... :)

> > just one comment on "lenny: wait for apt-xapian-index running in the
> > background": using sleep here is an antipattern, as its rather random
> > how long it will take. I guess you know that... :)
> 5s should be more than sufficient, 30s is just safety net for a stupid
> package in lenny. RC bug don't help in that case.

hm, ok

> > deploying now... and: are we ready for an upload now?
> let me try to dig out some more first ...

ok, but please dont wait to long, else I'll just upload, as after 
upload is before upload anyway :)


-- 
cheers,
	Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/piuparts-devel/attachments/20181015/c7a94bcb/attachment.sig>


More information about the Piuparts-devel mailing list