[Piuparts-devel] First step to Python 3

[Holger Levsen]

Hi Herbert,

On Mon, Jan 14, 2019 at 10:10:16AM -0200, Herbert Fortes wrote:
> I am a newbie but I am trying to put Piuparts
> to work with Python 3 only.

wheehoooo, that's awesome!

> This mornning I did:
> 
> Changes not staged for commit:
> 
> 	modified:   piuparts.py
> 	modified:   piupartslib/__init__.py
> 	modified:   piupartslib/conf.py
> 	modified:   piupartslib/packagesdb.py
> 	modified:   piupartslib/pkgsummary.py

very nice, though that still misses some files:

master-bin/detect_well_known_errors.py
piuparts-analyze.py
piupartslib/dwke.py
piupartslib/dependencyparser.py
piuparts-master-backend.py
piuparts-report.py
piuparts-slave.py
tests/test_piuparts.py
tests/test_pkgsummary.py
tests/test_dependencyparser.py
tests/test_config.py
tests/unittests.py

But it's a really good start!

> And tests are OK:

as said: very nice!

 
> Basically I fix some imports like
[...]

looks good to me!

> python-lzma seems to be for tests too (piupartslib/__init__.py).
> piuparts-common package has it for 'Depends'.

what's your question/comment here?

> piuparts (0.66) unstable; urgency=medium

I'm hope you were need basing your work on this ancient version?

> With Python 3.7 I think it can be removed. I do not
> have it installed.

I believe we should target python 3.7 as this is for bullseye (the
release after buster) anyway.

> I saw that branch python3 last commit was 3 years ago.
> I did not use it.

:)

> Should I continue with these minor changes? 

yes, please!

also please push your work as a branch somewhere.

> Tests pass but
> they do not cover 50%.

is that any different from now?

> I am not in the list. Please Cc.

done. thanks again!


-- 
cheers,
	Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/piuparts-devel/attachments/20190114/3d73c202/attachment.sig>