[Piuparts-devel] First step to Python 3 - PR

[Herbert Fortes]

On 1/16/19 12:52 PM, Herbert Fortes wrote:
> 
> Hi,
> 
> I am without access to Salsa. I did a fork at
> Github and made a PR[0] to the fork
> 
> [0] - https://github.com/hpfn/piuparts_3/pull/2/commits/3caf95fc5cf38852fd27e2dcd03f774b1d616954
> 
> the fork is a 'git clone' from this mornning.
> 
> 
> 504  piuparts /var/cache/apt/archives/btcheck_2.1-4_amd64.deb
> 505  piuparts /var/cache/apt/archives/python2.7_2.7.15-5_amd64.deb 
> 506  piuparts /var/cache/apt/archives/libpython-stdlib_2.7.15-3_amd64.deb 
> 508  piuparts /var/cache/apt/archives/gifsicle_1.91-5_amd64.deb 
> 
> INFO: PASS: All tests.
> INFO: piuparts run ends.

the PR has theses results. It is OK.

> 
> I edited each file again. I did not copy/paste what
> I did yesterday. I have problems this time. 
> 
> 
> FAIL: Installation and purging test.
> 
> To help me find the error changed 'ok = False' for 'return False'
> in 'chech_results' (it is not in PR). The problem was in
> 
> piuparts: 1990 - diff_meta_data()
> 
> The function has tree1 and tree2 params but do:
> (changes in the PR)
> 
> -tree1= tree1.copy()
> -tree2 = tree2.copy()
> +tree1= tree1_p.copy()
> +tree2 = tree2_p.copy()
> 
> 
> I only made the change when in a loop. To not change
> the iterator during loop.
> 
> But there is a 'if' before the loops with the changes
> that checks tree1 and tree2 and do a 'del tree[XXX]'.
> 
> Today I do not know if it is necessary to edit here:

Do the check first and then do the dict.copy() ?


> 
> (piuparts: line 1997)
> for name in settings.ignored_files:
>         if name[0] == ':':
>             verbose = not quiet
>             name = name[1:]
>         else:
>             verbose = False
>         if name in tree1:  # HERE
>             if verbose:
>                 logging.info("IGNORED PATH at 1: %s" % name)
>             del tree1[name]  # HERE
>         if name in tree2:  # HERE
>             if verbose:
>                 logging.info("IGNORED PATH at 2: %s" % name)
>             del tree2[name]  # HERE
> 
> 
> 
> Regards,
> Herbert
>