[Pkg-acpi-devel] Bug#564169: Bug#564169: acpi-support should depend on rfkill

[Sebastian Leske]

Hi,

On Tue, 12 Jan 2010 16:15:31 +0100, Michael Meskes <meskes at debian.org>
wrote:
>> They press Fn-F5, but nothing happens. They look into the system logs:
>> nothing. They conclude that acpi-support does not support Fn-F5.
>> 
>> Your fix will not really help that user.
> 
> True. But don't forget that your package manager will tell you about
> rfkill, so
> you could have installed it.

yes, that is true. That was my point: the package manager will tell me that
rfkill is a "Suggest" or "Recommend", but it will not say what it's needed
for. That's why I wrote that it would be useful to have some kind of
comment with a Suggest/Recommend to tell users *why* it's recommended.
Maybe that'll come one day...

>> * Explain in the package description where rfkill is needed:
>> "Install rfkill to enable toggling WLAN on Thinkpad laptops."
> 
> No, this will bloat the description. I don't think this is acceptable
> either. I
> think the best place to put this is
> /usr/share/doc/acpi-support/README.thinkpad.

Yes, that sounds reasonable. Maybe the package description could note that
/usr/share/doc/acpi-support/README.thinkpad.
(or /usr/share/doc/acpi-support/README* ) contains useful information for
users :-).

>> * Put some hint into ibm-wireless.sh about rfkill, e.g.:
>> Replace
>> test -x /usr/sbtest -x /usr/sbin/rfkill  || exit 0
>> with
>> 
>> if (! test -x /usr/sbin/rfkill)
>> then
>> logger "Error: Please install package rfkill to enable toggling of
>> wireless
>> devices." ;exit 0
>> fi
> 
> This sounds good. 

That's good :-).

Greetings,

S.Leske