[Pkg-alsa-devel] Bug#323331: marked as done ([patch] ld10k1 not
64bit clean.)
Debian Bug Tracking System
owner at bugs.debian.org
Tue Nov 22 23:33:08 UTC 2005
Your message dated Tue, 22 Nov 2005 15:17:09 -0800
with message-id <E1EehNt-0006rF-Qo at spohr.debian.org>
and subject line Bug#323331: fixed in alsa-tools 1.0.10-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 16 Aug 2005 03:37:37 +0000
>From warp at babylon.d2dc.net Mon Aug 15 20:37:37 2005
Return-path: <warp at babylon.d2dc.net>
Received: from spock.bluecherry.net [66.138.159.248]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1E4sGf-0000Ws-00; Mon, 15 Aug 2005 20:37:37 -0700
Received: from babylon.d2dc.net (unknown [12.37.209.73])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client did not present a certificate)
by spock.bluecherry.net (Postfix) with ESMTP id 7114F1DB0E
for <submit at bugs.debian.org>; Mon, 15 Aug 2005 22:37:35 -0500 (CDT)
Received: by babylon.d2dc.net (Postfix, from userid 1000)
id 496DAD87C0; Mon, 15 Aug 2005 23:37:31 -0400 (EDT)
Date: Mon, 15 Aug 2005 23:37:31 -0400
From: "Zephaniah E. Hull" <warp at babylon.d2dc.net>
To: submit at bugs.debian.org
Subject: [patch] ld10k1 not 64bit clean.
Message-ID: <20050816033731.GA6397 at babylon.d2dc.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="/04w6evG8XlLl3ft"
Content-Disposition: inline
X-Notice-1: Unsolicited Commercial Email (Aka SPAM) to ANY systems under
X-Notice-2: our control constitutes a $US500 Administrative Fee, payable
X-Notice-3: immediately. By sending us mail, you hereby acknowledge that
X-Notice-4: policy and agree to the fee.
User-Agent: Mutt/1.5.9i
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: ld10k1
Version: 1.0.9-1
Severity: grave
Tags: patch, upstream
On all 64bit systems (the easiest example is amd64) ld10k1 crashes on
use by lo10k1, some debugging tracked down the problem fairly quickly.
The bitops functions (set_bit and associated) that ld10k1 use come from
the linux kernel, and assume that longs are 32bit only, causing a buffer
overflow of the bit buffer.
The attached patch fixes the bitops to be independent of the size of
longs, and is confirmed to fix the bug on my box.
Zephaniah E. Hull.
--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ld10k1.diff"
diff -ur alsa-tools-1.0.9/ld10k1/src/bitops.h alsa-tools-1.0.9.mine/ld10k1/src/bitops.h
--- alsa-tools-1.0.9/ld10k1/src/bitops.h 2005-03-18 08:41:02.000000000 -0500
+++ alsa-tools-1.0.9.mine/ld10k1/src/bitops.h 2005-08-15 23:24:46.000000000 -0400
@@ -15,13 +15,17 @@
*
* C language equivalents written by Theodore Ts'o, 9/26/92
*/
+/*
+ * Converted to be independent of the size of longs.
+ * Zephaniah E. Hull 2005-08-15.
+ */
__inline__ int set_bit(int nr, unsigned long * addr)
{
int mask, retval;
- addr += nr >> 5;
- mask = 1 << (nr & 0x1f);
+ addr += nr >> (sizeof(long) + 1);
+ mask = 1 << (nr & (sizeof(long) * 8 - 1));
retval = (mask & *addr) != 0;
*addr |= mask;
return retval;
@@ -31,8 +35,8 @@
{
int mask, retval;
- addr += nr >> 5;
- mask = 1 << (nr & 0x1f);
+ addr += nr >> (sizeof(long) + 1);
+ mask = 1 << (nr & (sizeof(long) * 8 - 1));
retval = (mask & *addr) != 0;
*addr &= ~mask;
return retval;
@@ -42,8 +46,8 @@
{
int mask;
- addr += nr >> 5;
- mask = 1 << (nr & 0x1f);
+ addr += nr >> (sizeof(long) + 1);
+ mask = 1 << (nr & (sizeof(long) * 8 - 1));
return ((mask & *addr) != 0);
}
--/04w6evG8XlLl3ft--
---------------------------------------
Received: (at 323331-close) by bugs.debian.org; 22 Nov 2005 23:22:59 +0000
>From katie at ftp-master.debian.org Tue Nov 22 15:22:59 2005
Return-path: <katie at ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
id 1EehNt-0006rF-Qo; Tue, 22 Nov 2005 15:17:09 -0800
From: Jordi Mallach <jordi at debian.org>
To: 323331-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#323331: fixed in alsa-tools 1.0.10-1
Message-Id: <E1EehNt-0006rF-Qo at spohr.debian.org>
Sender: Archive Administrator <katie at ftp-master.debian.org>
Date: Tue, 22 Nov 2005 15:17:09 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: alsa-tools
Source-Version: 1.0.10-1
We believe that the bug you reported is fixed in the latest version of
alsa-tools, which is due to be installed in the Debian FTP archive:
alsa-firmware-loaders_1.0.10-1_i386.deb
to pool/contrib/a/alsa-tools/alsa-firmware-loaders_1.0.10-1_i386.deb
alsa-tools-gui_1.0.10-1_i386.deb
to pool/main/a/alsa-tools/alsa-tools-gui_1.0.10-1_i386.deb
alsa-tools_1.0.10-1.diff.gz
to pool/main/a/alsa-tools/alsa-tools_1.0.10-1.diff.gz
alsa-tools_1.0.10-1.dsc
to pool/main/a/alsa-tools/alsa-tools_1.0.10-1.dsc
alsa-tools_1.0.10-1_i386.deb
to pool/main/a/alsa-tools/alsa-tools_1.0.10-1_i386.deb
alsa-tools_1.0.10.orig.tar.gz
to pool/main/a/alsa-tools/alsa-tools_1.0.10.orig.tar.gz
ld10k1_1.0.10-1_i386.deb
to pool/main/a/alsa-tools/ld10k1_1.0.10-1_i386.deb
liblo10k1-0_1.0.10-1_i386.deb
to pool/main/a/alsa-tools/liblo10k1-0_1.0.10-1_i386.deb
liblo10k1-dev_1.0.10-1_i386.deb
to pool/main/a/alsa-tools/liblo10k1-dev_1.0.10-1_i386.deb
qlo10k1_1.0.10-1_i386.deb
to pool/main/a/alsa-tools/qlo10k1_1.0.10-1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 323331 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jordi Mallach <jordi at debian.org> (supplier of updated alsa-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 22 Nov 2005 23:46:53 +0100
Source: alsa-tools
Binary: liblo10k1-dev alsa-tools alsa-tools-gui ld10k1 liblo10k1-0 qlo10k1 alsa-firmware-loaders
Architecture: source i386
Version: 1.0.10-1
Distribution: unstable
Urgency: low
Maintainer: Jordi Mallach <jordi at debian.org>
Changed-By: Jordi Mallach <jordi at debian.org>
Description:
alsa-firmware-loaders - ALSA software loaders for specific hardware
alsa-tools - Console based ALSA utilities for specific hardware
alsa-tools-gui - GUI based ALSA utilities for specific hardware
ld10k1 - ALSA emu10k1/2 patch loader
liblo10k1-0 - ALSA emu10k1/2 patch-loader library
liblo10k1-dev - ALSA emu10k1/2 patch-loader library development files
qlo10k1 - ALSA ld10k1 utility
Closes: 209012 323331
Changes:
alsa-tools (1.0.10-1) unstable; urgency=low
.
* New upstream release
.
alsa-tools (1.0.9+1.0.10rc2-1) experimental; urgency=low
.
* New upstream release candidate
* Thomas Hood
- debian/control: s/Architecture: any/Architecture: <Linux arches>/
.
alsa-tools (1.0.9+1.0.10rc1-1) experimental; urgency=low
.
* New upstream release
- Closes: #323331 (ld10k1 not 64bit clean)
Thanks to Zephaniah E. Hull.
* Jordi Mallach:
- debian/control: fix formatting of descriptions, so aptitude displays
them correctly.
- debian/alsa-tools.copyright, debian/alsa-tools-gui.copyright: group
GPL and LGPL copyright notices to avoid duplicating the same blurb
over and over. Thanks to Joerg Jaspert for the suggestion.
* Thomas Hood
- Update upstream changelog
- Use newfangled (>= 3.0-2) lsb-base init functions and accordingly...
- Depend on new (>= 3.0-3) version of lsb-base
- Build-Depend on new libasound2-dev
.
alsa-tools (1.0.9-1) experimental; urgency=low
.
* Upload to Debian (Closes: #209012)
* Mikael Magnusson
- New upstream release
- Remove patches applied upstream
- Add copyright file for each binary package
- Eliminate EMU10K1.conf diversion; put modified EMU10K1.conf
in examples/
* Thomas Hood
- Revise ld10k1 initscript, hopefully not breaking it in the process
- Tweak descriptions and copyright files
- Add upstream change log
- In liblo10k1-dev include symlinks to change logs in liblo10k1-0
instead of copies
- Bump Standards-Version to 3.6.2.1; no changes required
* Jordi Mallach
- Build-Depend on libqt3-mt-dev >= 3:3.3.4-4 for the C++ ABI
transition
Files:
eaca4026a7665eb95b5ed1078ee2ea58 1040 sound extra alsa-tools_1.0.10-1.dsc
e709b9c16e9cb8dfcaa7046d23530084 2195419 sound extra alsa-tools_1.0.10.orig.tar.gz
a9b10dc58bad4bd71aae01727d2a46d4 18228 sound extra alsa-tools_1.0.10-1.diff.gz
17bebfc7f336eec6a1a070ae5a96c8e8 76590 sound extra alsa-tools_1.0.10-1_i386.deb
73be31200c4436523e9ca80858de1670 260654 sound extra alsa-tools-gui_1.0.10-1_i386.deb
3a556b5c14dd642598ea51b5776a48dc 26828 contrib/sound extra alsa-firmware-loaders_1.0.10-1_i386.deb
840a47e5d73411fab21c69a93b16eadd 97572 sound extra ld10k1_1.0.10-1_i386.deb
1c85d2da7bea802533ca8fefae1b9c2c 25452 libs extra liblo10k1-0_1.0.10-1_i386.deb
fbd7d7ad9604a54a833533a553394456 29542 devel extra liblo10k1-dev_1.0.10-1_i386.deb
4042f9c6fceb31684cf7d27de09dff4d 134734 sound extra qlo10k1_1.0.10-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDg6VMJYSUupF6Il4RArtaAKDK12ziMJqIqv2GMAcHAFHs6BPexACePwau
Mt6Fmi6WCw9EuTOyKsy0aGc=
=mht+
-----END PGP SIGNATURE-----
More information about the Pkg-alsa-devel
mailing list