[pkg-bacula-devel] Bug#672285: Bug#672285: bacula-director-sqlite3 package don't cleanup database after purging.

[Alexander Golovko]

On Mon, 14 May 2012 14:18:42 +0200, Luca Capello wrote:
> Hi Alexander!
>
> On Wed, 09 May 2012 20:07:59 +0200, Alexander Golovko wrote:
>> bacula-director-sqlite3 package don't cleanup database on purging.
>>
>> dbconfig-common not used in prerm and postrm scripts.
>
> Is not this related to #670427?  If so, the two bugs should be 
> merged.
>

Yes, this is related bugs.

> However, what does 'cleanup database on purging' means?  That the SQL
> database is not removed when purging?  In this case, what do similar
> packages?

on package purging dbconfig-common ask a question, purge database or 
not.
in case of sqlite3 database purging == removing file from disk


>
>> [2. text/plain; bacula-director-sqlite3-correct-db-purge.patch]
>>
>> diff --git a/debian/bacula-director-sqlite3.postrm 
>> b/debian/bacula-director-sqlite3.postrm
>> index bd21108..ba8aca0 100644
>> --- a/debian/bacula-director-sqlite3.postrm
>> +++ b/debian/bacula-director-sqlite3.postrm
>> @@ -4,10 +4,21 @@
>>  # see: dh_installdeb(1)
>>
>>  if [ -f /usr/share/debconf/confmodule ]; then
>> -	. /usr/share/debconf/confmodule
>> +    . /usr/share/debconf/confmodule
>
> This is wrong, please use the same coding style as in previous 
> entries
> or, if you want to change it, do so in a separate commit.

Sorry, there are different code styling in different scripts.
I make this line like same line in mysql.postrm

>
> The other part of the patch depends on my question above, but it 
> should
> be adapted to Hauke's development2 branch.

Ok, i rebase my branch.


>
> Thx, bye,
> Gismo / Luca

-- 
with best regards,
Alexander Golovko
email: alexandro at ankalagon.ru
xmpp: alexandro at ankalagon.ru