[pkg-bacula-devel] Bug#646730: bacula: drops readline support if rebuilt

[Sven Joachim]

On 2012-05-17 21:38 +0200, Luca Capello wrote:

> On Wed, 26 Oct 2011 18:33:42 +0200, Sven Joachim wrote:
>> ,----
>> | Configuration on Fri Oct 21 15:28:34 UTC 2011:
>> | [...]
>> |    Large file support:	    yes
>> |    Bacula conio support:    no 
>> |    readline support:	    no 
>> `----
>>
>> Adding libncurses-dev to Build-Depends should avoid this.
>
> First, I thought this was due to the split between libncurses and
> libtinfo, in a sort "reflected" in the readline debian/changelog:
>
> readline6 (6.2-6) unstable; urgency=low
>
>   * lib{,32}readline6-dev: Depend on lib{,32}tinfo-dev instead of
>     lib{,32}ncurses5-dev.
>   * Don't link rlfe against any libncurses* library.
>
>  -- Matthias Klose <doko at debian.org>  Tue, 04 Oct 2011 16:33:44 +0200
>
> readline6 (6.2-5) unstable; urgency=low
>
>   * Do not link against any libncurses* library, just against libtinfo.
>   * Fix corrupt display for history search in vi-mode, 256-color prompt
>     (Micah Cowan). Closes: #614718, LP: #721982.
>   * Remove unused build-dep on lsb-release. Closes: #642383.
>
>  -- Matthias Klose <doko at debian.org>  Sat, 01 Oct 2011 11:56:50 +0200

This is correct, that change triggered the problem.

> However, simply adding libtinfo-dev was not enough, here are the
> differences in my pbuilder logs with libtinfo-dev and libncurses-dev:

Also correct, libtinfo-dev does not include any headers[1], and it's
already pulled in by libreadline6-dev.

>> However,
>> consider patching the upstream build system which erroneously believes
>> that ncurses is necessary for linking with readline.
>
> While I am not an ncurses/readline expert, I think that upstream is
> correct, according to the upstream manual:
>
>   <http://www.bacula.org/5.2.x-manuals/en/main/main/System_Requirements.html>
>
>   * If you want to enable command line editing and history, you will
>     need to have /usr/include/termcap.h and either the termcap or the
>     ncurses library loaded (libtermcap-devel or ncurses-devel).

This is only "correct" because their configure script checks for it.
AFAICS the only file that actually #includes an ncurses header is
src/console/conio.c, and that should not be built with
"--disable-conio".

However, there are a literally a hundred dpkg-shlibdeps warnings about
useless dependencies, so it's probably not worth trying to fix this
particular one.

> Fix applied in the Git repository:
>
>   <http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commitdiff;h=c71e91fb4d6f7434786f1d36eeeb0b0506a2216c>

Actually, the 5.0.3+dfsg-0.1 NMU[2] already added libncurses5-dev to
Build-Depends, consider incorporating it into your git repository.

Cheers,
       Sven


1. See #644426 for a discussion about that topic.
2. http://packages.qa.debian.org/b/bacula/news/20120430T091734Z.html