[pkg-bacula-devel] bacula-tray-monitor

[Sven Hartge]

On 09.12.18 18:14, Carsten Leonhardt wrote:
> Hi,
> 
>> I tested this and it look really nice. I also changed the
>> bacula-tray-monitor.desktop to reference the Icon by name instead of
>> path, so the correct Icon will always be selected from
>> /usr/share/icons/*/apps/.
> 
>> I also choose to include a pre-exported PNG to get rid of the
>> imagemagick build-dep, because including this monstrosity just to
>> convert one file from SVG to PNG feels wrong. It also could create
>> reproducibility issues if imagemagick decides to change their code in
>> the future, resulting in slightly different images.
> 
> ok, I just have two questions:
> 
>  - Why do we include the icon in debian/additions when it's already in
>    src/qt-console/images?

Because when I inspected the SVG, inkscape complained about it being of
an older SVG format, so I converted and optimized it. Also this way we
are independent of any changes upstream may make in the future.

>  - We should consider if it's ok for users to have different icons on
>    different distributions. So far it seems that only Fedora is shipping
>    the tray-monitor and they use the "generic.xpm" (judging from my list
>    at the end of debian/TODO)

But that icon sucks! :) I think there is a reason generic.xpm vanished
with 7.0. Besides Policy seems to say to not use XPM anymore.

> (I'm also amazed at how much time, energy and discussion we can put into
> an icon...)

Well, when there is nothing else to do ...

Grüße,
Sven.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-bacula-devel/attachments/20181209/426f3f69/attachment.sig>