[pkg-bacula-devel] Bug#1097421: mtx: ftbfs with GCC-15

[Matthias Klose]

Package: src:mtx
Version: 1.3.12-17
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/mtx_1.3.12-17_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
config.status: creating config.h
   dh_auto_build
	make -j8
make[1]: Entering directory '/build/reproducible-path/mtx-1.3.12'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/mtx-1.3.12=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -DVERSION="\"1.3.12\"" -I. -I. -DLONG_PRINT_REQUEST_SENSE=1  -c -o mtx.o mtx.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/mtx-1.3.12=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -DVERSION="\"1.3.12\"" -I. -I. -DLONG_PRINT_REQUEST_SENSE=1  -c -o mtxl.o mtxl.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/mtx-1.3.12=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -DVERSION="\"1.3.12\"" -I. -I. -DLONG_PRINT_REQUEST_SENSE=1  -c -o tapeinfo.o tapeinfo.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/mtx-1.3.12=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -DVERSION="\"1.3.12\"" -I. -I. -DLONG_PRINT_REQUEST_SENSE=1  -c -o loaderinfo.o loaderinfo.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/mtx-1.3.12=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -DVERSION="\"1.3.12\"" -I. -I. -DLONG_PRINT_REQUEST_SENSE=1  -c -o scsitape.o scsitape.c
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/mtx-1.3.12=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -DVERSION="\"1.3.12\"" -I. -I. -DLONG_PRINT_REQUEST_SENSE=1  -c -o scsieject.o scsieject.c
In file included from loaderinfo.c:40:
mtx.h:225:16: error: cannot use keyword ‘false’ as enumeration constant
  225 | typedef enum { false, true } boolean;
      |                ^~~~~
mtx.h:225:16: note: ‘false’ is a keyword with ‘-std=c23’ onwards
In file included from mtxl.c:29:
mtx.h:225:16: error: cannot use keyword ‘false’ as enumeration constant
  225 | typedef enum { false, true } boolean;
      |                ^~~~~
mtx.h:225:16: note: ‘false’ is a keyword with ‘-std=c23’ onwards
make[1]: *** [<builtin>: loaderinfo.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from tapeinfo.c:51:
mtx.h:225:16: error: cannot use keyword ‘false’ as enumeration constant
  225 | typedef enum { false, true } boolean;
      |                ^~~~~
mtx.h:225:16: note: ‘false’ is a keyword with ‘-std=c23’ onwards
In file included from scsitape.c:42:
mtx.h:225:16: error: cannot use keyword ‘false’ as enumeration constant
  225 | typedef enum { false, true } boolean;
      |                ^~~~~
mtx.h:225:16: note: ‘false’ is a keyword with ‘-std=c23’ onwards
scsitape.c: In function ‘execute_command’:
scsitape.c:149:30: warning: comparison of constant ‘-1’ with boolean expression is always false [-Wbool-compare]
  149 |         if (!MediumChangerFD == -1)
      |                              ^~
scsitape.c:149:30: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
scsitape.c:149:13: note: add parentheses around left hand side expression to silence this warning
  149 |         if (!MediumChangerFD == -1)
      |             ^~~~~~~~~~~~~~~~
      |             (               )
In file included from mtx.c:39:
mtx.h:225:16: error: cannot use keyword ‘false’ as enumeration constant
  225 | typedef enum { false, true } boolean;
      |                ^~~~~
mtx.h:225:16: note: ‘false’ is a keyword with ‘-std=c23’ onwards
In file included from scsieject.c:25:
mtx.h:225:16: error: cannot use keyword ‘false’ as enumeration constant
  225 | typedef enum { false, true } boolean;
      |                ^~~~~
mtx.h:225:16: note: ‘false’ is a keyword with ‘-std=c23’ onwards
scsitape.c: In function ‘S_read’:
scsitape.c:867:33: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  867 |                                 write(outfile,buffer,len);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
scsitape.c:887:41: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  887 |                                         write(outfile,buffer,len);
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
scsitape.c:899:25: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  899 |                         write(outfile,buffer,len);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [<builtin>: scsieject.o] Error 1
make[1]: *** [<builtin>: scsitape.o] Error 1
make[1]: *** [<builtin>: tapeinfo.o] Error 1
make[1]: *** [<builtin>: mtxl.o] Error 1
make[1]: *** [<builtin>: mtx.o] Error 1
make[1]: Leaving directory '/build/reproducible-path/mtx-1.3.12'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2