[Pkg-bazaar-maint] Querying potentially undesirable change to bzr/unstable

[Max Bowsher]

On 13/04/11 07:34, Max Bowsher wrote:
> In regards to:
> 
> 3924: Jelmer Vernooij 2011-04-04 Use makefile rather than setup to build.
> 
> maxb at chimaera:~/wc/bzr/bzr/unstable$ bzr diff -c 3924
> ...
> === modified file 'debian/rules'
> --- debian/rules	2011-03-07 11:29:02 +0000
> +++ debian/rules	2011-04-04 21:49:26 +0000
> @@ -1,7 +1,7 @@
>  #!/usr/bin/make -f
> 
>  %:
> -	dh --with python2 --buildsystem=python_distutils $*
> +	dh --with python2 $*
> 
>  ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
>  CONCURRENCY = BZR_CONCURRENCY=$(patsubst parallel=%,%,$(filter
> parallel=%,$(DEB_BUILD_OPTIONS)))
> 
> 
> 
> And, for additional context, note that the
> override_dh_auto_{build,install} targets then override the buildsystem
> mode back to python_distutils.
> 
> I don't like it very much that we are now running some of our dh
> subcommands with one dh buildsystem module and some of them with another
> - it seems fragile and mysterious. Also it's contrary to what the commit
> message implies was intended.

And this change has also been silently reverted on the 2.4 branch during
a merge commit.

On that additional basis, I'm going to undo it on the 2.3 branch too.

Max.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-bazaar-maint/attachments/20110515/9a5b9c82/attachment.pgp>