updated patch for 5.8.16

Thibaut VARENE T-Bone at parisc-linux.org
Sun Mar 4 01:43:56 CET 2007


Just for the records, there's a nasty bug in 5.8.16: (CC'ing boinc-dev as
they might be interested)

- in client/hostinfo_unix.C:251
char buf[256], features[1024], model_buf[1024];

- in lib/hostinfo.h:45
char p_model[256];

- in client/hostinfo_unix.C:335
strlcpy(host.p_model, model_buf, sizeof(host.p_model));

/Oops.../

Meaning that even though we have enough space to get all the funky
features of our cpus, we will never have enough space to write it back
into the host structure...

This has interesting outcomes such as (on my core2duo box):
2007-03-04 00:49:21 [---] Processor: 2 GenuineIntel Intel(R) Core(TM)2 CPU
    6300  @ 1.86GHz [Family 6 Model 15 Stepping 6][fpu vme de pse tsc msr
pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx
fxsr sse sse2 ss ht tm syscall nx lm constant_tsc pni monitor ds_cpl vmx
est tm2 ss

In case it's not obvious, the flags have been truncated:
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm syscall nx
lm constant_tsc pni monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr lahf_lm

HTH

T-Bone

PS: boinc-dev, I've sent out a patch to the debian BTS which relates to
that bit of code, so you might be interested in it, sorry for not sending
it your way in the first place:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=406853#35

please CC-me on reply, I'm not subscribed

-- 
Thibaut VARENE
http://www.parisc-linux.org/~varenet/



More information about the pkg-boinc-devel mailing list