[Pkg-clamav-devel] LogRotate, create user and the option in the config

[Sebastian Andrzej Siewior]

On 2014-04-04 15:07:31 [+0200], Andreas Cadhalpun wrote:
> Hi Scott,
Hi,

> On 04.04.2014 14:44, Scott Kitterman wrote:
> >You can manage your configuration exclusively through Debconf or exclusively
> >through hand editing the files. Mixing the two methods can have bad results.
> >The Debconf method has been supported since approximately forever and I don't
> >think we should drop it.

mixing is one thing. I more frightend about the growing amount of
possible test cases after adding test cases. But if you think it is
reasonable to keep this as it helps the user then be it. I though it
might clever to put an end to this.

> Then let's keep it. Though we still have to something about the LogRotate
> option needing dpkg-reconfigure of other packages.

Please split the debconf stuff into the proper package. Have clamd,
freshclam and milter and each one can run under a separate user. That
means if you dpkg-reconfigure then you only switch its values. This
includes logrotate and we get the file recreated (properly). Same goes
for freshclam and milter.

> >I do question the value of having clamav rotate its logs. I suspect people are
> >getting double rotation sometimes due to both the package and system logrotate
> >being active. I think we should pick one.
> >
> >I think it should be the system logrotate and the package option should be disabled.
> 
> This sounds reasonable.

I agree, I prefer having one place (etc/logroate.d) to do the rotation.
However, the daemon will rotate the logfile (even if it disabled) if the logfile
exceeds the configured size.

> Best regards,
> Andreas

Sebastian