[Pkg-clamav-devel] LogRotate, create user and the option in the config

Sebastian Andrzej Siewior sebastian at breakpoint.cc
Wed Mar 26 22:07:17 UTC 2014


On 2014-03-26 03:26:41 [-0400], Scott Kitterman wrote:
> > Would it make sense to move the logrotate part into the individual
> > package (before now I wasn't aware that freshclam has also one :)) so
> > that logrotate.d files and the .conf are update after the change has
> > been made? That would then properly close #669287 then.
> 
> Before clamav had this new LogRotate option, the system handled it itself.  
> The more I'm looking at it, the more I think we should make LogRotate false 
> and set the file size option to 0 and not have clamav anything about rotating 
> the files.  Let lograte do it like it did before.  We've clearly added a bunch 
> more complexity to potentially expose to the user and I'm not sure what it 
> buys.  

I think the whole debconf thingy got a little out of hand. Almost every
option in the config file can be changed. As you say, it adds complexity
atm. Maybe too much since we are now busy to get it bug free.

I do get a little anxious if I want to change one option and have to
click my self carefully through the options so I don't get press enter
too often… That is maybe my own problem here. I don't use this on my
servers, just now for testing.
Anyway. What do we gain here exactly? What is the advantage of using debconf
for every config item over giving a sane default config with a comment over
each option?
I understand that for things like LogRotate it is pleasant that the logrotate.d
file is automaticly created with the proper user for instance. However
this isn't working perfectly atm and I didn't find other example. The
other options seem to written to the config file as-is.

Looking at apache, nginx, exim for instance they all ship a default
config which works and leave it up to the user to deal with it. Exim has
a few questions, true, but they mostly compare to what freshclam asks
and are way less compared to `base'. unbound gives a config file with a
lot of comments next to each option. That is what _I_ like.

Said that I wouldn't mind if we drop the LogRotate option(s). I wouldn't
even mind if we drop them all. Well. freshclam has the usefull question
where you can choose between daemon, cron, and so on. I consider this
usefull.

> Scott K

Sebastian



More information about the Pkg-clamav-devel mailing list