[Pkg-clamav-devel] tomfastmath is ready

[Sebastian Andrzej Siewior]

On Wed, Mar 11, 2015 at 09:00:21PM +0100, Andreas Cadhalpun wrote:
> Hi Sebastian,
Hi Andreas,

> >>     cid #11125/#11126
> >
> >those two are not bug ids but someting from an auto-testing tool. It
> >does not make sense.
> 
> These are coverity IDs, but it's not obvious what they are about.
> If upstream also doesn't understand it, it should be fine to ignore them.

Right, covertity that was.

> >I defined four symbols optional which are only exported on 32bit
> >architectures. The longterm plan to fix this properly is to wait for
> >dpkg 1.18 which defines the tag arch-bits= or to ask upstream those
> >symbols are worth exporting or should remain for internal usage. I tend
> >to the later.
> 
> As long as nothing uses these symbols, it doesn't matter much.

I added a symbol file to linking. I removed the "combo" symbols from beeing
exported since it is enough to use them internally. I pushed this to upstream
and I am waiting for response. But since those functions are the unrolled
versions of the "base" function I don't see any reason to export them.

> I pushed a patch, which allows building clamav against the system
> tomsfastmath library, if it is detected and otherwise uses the embedded
> copy.
> With the current libtfm it seems to work fine, so once it is in the archive,
> we can just replace the (useless) libtommath-dev dependency with libtfm-dev.

Hehe. Right.

> Best regards,
> Andreas

Sebastian