[Pkg-clamav-devel] tomfastmath is ready

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Fri Mar 27 16:45:04 UTC 2015


Hi Sebastian,

On 26.03.2015 22:09, Sebastian Andrzej Siewior wrote:
> I added a symbol file to linking. I removed the "combo" symbols from beeing
> exported since it is enough to use them internally. I pushed this to upstream
> and I am waiting for response. But since those functions are the unrolled
> versions of the "base" function I don't see any reason to export them.

Yes, it's probably best to hide these implementation details from the API/ABI.
But then the function declarations should be moved from the installed tfm.h
header to a private one, e.g. tfm_private.h.
There are some more functions in the section 'VARIOUS LOW LEVEL STUFFS',
which could also be made private (s_fp_add, s_fp_sub, fp_reverse).

Best regards,
Andreas



More information about the Pkg-clamav-devel mailing list