[pkg-cryptsetup-devel] Bug#546610: cryptsetup: root= cmdline call is not honoured by initrd in crypto+lvm (Was initramfs-tools: ...)

[Agustin Martin]

On Fri, Sep 25, 2009 at 04:31:27PM +0200, Agustin Martin wrote:
> On Thu, Sep 24, 2009 at 09:29:58PM +0200, Jonas Meurer wrote:
> > first, thanks for the bugreport. the reason for change of bahaviour is a
> > line in /usr/share/initramfs/scripts/local-top/cryptroot that sets $ROOT
> > to $NEWROOT in /conf/params.conf in the initramfs:
> > 
> > 302:			if [ "$cryptrootdev" = "yes" ]; then
> > 303:				# required for lilo to find the root device
> > 304:				echo "ROOT=$NEWROOT" >> /conf/param.conf
> > 305:			fi
> > 
> > commenting out these lines and regenerating the initramfs
> > (update-initramfs -u) afterwards should fix it. could you verify that?
> 
> Working well with that change. Thanks for debugging.
> 
> > unfortunately these lines are required in order to support setups with
> > cryptroot on lvm and lilo as bootloader. thus i don't know what to do
> > about that bug yet. will have to do further investigation and testing
> > with lilo as bootloader first.
> 
> I have been playing with attached patch. However, I have just noticed that
> it does not play nicely with more than one cryptopts= entry in cmdline. 
> Since I am not familiar with the code, I cannot discard other drawbacks.

Played a bit more with this. See attached patch. It is only tested in my
box, and not extensively (that is, fully untested under lilo+lvm), but it
may be useful.

Cheers,

-- 
Agustin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: _usr_share_initramfs-tools_scripts_local-top_cryptroot.v3.diff
Type: text/x-diff
Size: 1096 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20091116/9b06783f/attachment.diff>