[pkg-cryptsetup-devel] Bug#585418: cryptsetup: drop vol_id and un_vol_id checks

[Christoph Anton Mitterer]

Package: cryptsetup
Version: 2:1.1.2-1
Severity: wishlist


Hi Jonas.


Last time you've noticed, that vol_id and un_vol_id are deprecated.
Today I had a look at them and I remembered why (as vol_id no longer
exists).

May I suggest that it's perhaps better for people if we'd simply drop
the two (or make them internally use blkid).

As far as I understand:
if test ! -x "/lib/udev/vol_id"; then
  echo " - WARNING: vol_id is not available, impossible to run checks."
  exit 0
fi

Will be always true and therfore the script will simply exit, right?

I guess that's bad, because when people deliberately added such a check
and it returns true.... it's probably not what they wanted, is it?


Cheers,
Chris.