[pkg-cryptsetup-devel] Bug#585496: cryptsetup: replace check scripts by new versions

Christoph Anton Mitterer calestyo at scientia.net
Thu Jun 10 23:40:13 UTC 2010


Package: cryptsetup
Version: 2:1.1.2-1
Severity: wishlist
Tags: patch


Hi Jonas.

I'd have written replacements for all of the current check scripts.
They should work identical to the current ones (I did some basic tests,
but please validate my code).

Improvements would be:
- All other check scripts use blkid and un_blkid internally.

- No longer depend on sed and dd (which may be not available, although this is unlikely).
- No longer use programs, which are most likely NOT available in initramfs images
  (xfsprogs, e2fsutils).
- Better check for swap, than binary games.


Other changes I've made:
- No longer check for the existence of blkid (this should be always there as util-linux
  is essential/required).
Regarding initramfs-images:
We should only add the actually used check script (if any) to it.
Should I provide a hook script for this?
We should then (if any is used) also at util-linux' blkid binary.
Should I provide a hook script for this?

- Use other wording (e.g. no longer "valid filesystem" as the scripts never check whether
  the filesystem is really valid)
- Give warnings with ext2, xfs, swap, vol_id and un_vol_id that they're deprecated, and
  one should switch do blkid/un_blkid.

Guess we can remove the deprecated ones in squeeze+1.


The inclusion of these scripts makes #585418 obsolete I guess.

Documentation of the scripts is found inside (POSIX-style).


Cheers,
Chris.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-progs.tar.bz2
Type: application/x-bzip2
Size: 2365 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100611/14a96f1d/attachment.bin>


More information about the pkg-cryptsetup-devel mailing list