[pkg-cryptsetup-devel] Bug#782024: Bug#782024: cryptsetup: [patch] fix remote unlock of encrypted root when plymouth is installed

[Guilhem Moulin]

On Fri, 18 Dec 2015 at 19:16:56 -0500, Richard Hansen wrote:
>  * why SIGKILL instead of SIGTERM?  seems too aggressive
>  * perhaps add a waitpid() after the kill() to ensure that a second
>    plymouth won't be run before the first one exits

Agreed, but unfortunately plymouth doesn't terminate on SIGTERM.

>  * why does cryptroot-unlock use /bin/ash instead of /bin/sh?
>  * there are lots of BusyBox ashisms in the cryptroot-unlock script,
>    many of which can be easily replaced with POSIX conformant code

POSIX's read builtin doesn't support the -s flag.  Sure we can replace
with stty with a trap to restore echo, but since busybox is a dependency
anyway I don't think it's worth it :-P

I've addressed the rest in the updated patch.  Thanks for your input!

-- 
Guilhem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cryptroot.patch
Type: text/x-diff
Size: 10872 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20151219/1c7071a5/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20151219/1c7071a5/attachment.sig>