[Pkg-electronics-devel] qflow VLSI chain

[أحمد المحمودي]

On Fri, Sep 12, 2014 at 07:11:06PM +0300, أحمد المحمودي wrote:
>   * In override_dh_install, you do: cp qrouter.sh qrouter
>     I think you should remove 'qrouter' in dh_clean, you can do this by 
>     adding 'qrouter' to a debian/clean file.
---end quoted text---

  Further comments:
  * You made the 01_remove_install_target.patch because upstream's 
    Makefile doesn't support $(DESTDIR), but what you've done is 
    practically disabling the install target, and doing the install work 
    by yourself (debian/install + the dh_install override). Which is a 
    headache to maintain with further versions of qrouter. I'd rather 
    patch Makefile.in to prepend the install target of every install 
    command with $(DESTDIR), I am attaching a modified patch to explain 
    what I've done. Hence there is no need for the override_dh_install 
    target, nor for debian/install.

  * I think that 02_hardening_and_symbols.patch should be sent to 
    upstream (along with the modified patch I'm sending you). It 
    won't hurt upstream at all, and that's how Makefiles in other 
    upstream projects look like anyway, so you're helping him making his 
    scripts better.

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_remove_install_target.patch
Type: text/x-diff
Size: 1587 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-electronics-devel/attachments/20140912/67a61de9/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-electronics-devel/attachments/20140912/67a61de9/attachment.sig>