[Pkg-electronics-devel] RFS: systemc/2.3.2-1 [NEW]

[Carsten Schoenert]

Hello Ahmed,

Am 05.07.18 um 08:19 schrieb أحمد المحمودي:
> Please sponsor the upload of the new package systemc
> 
> Package name    : sysyemc
> Version         : 2.3.2
> Upstream Author : Accellera
> URL             : https://www.accellera.org/downloads/standards/systemc
> License         : Apache-2.0
> Section         : electronics
> Description: SystemC library
>  SystemC is an HDL based on a C++ class library intended for
>  simulations using standard C++ tools.
> 
> It builds the following binary packages:
> libsystemc: SystemC library
> libsystemc-dev: Development files for SystemC library
> libsystemc-doc: Documentation for SystemC library
> 
> The package was checked using the latest version of lintian, and has the 
> following lintian warnings:
> 
> W: libsystemc: package-name-doesnt-match-sonames libsystemc-2.3.2
> 
> The package can be found on Git: 
> https://salsa.debian.org/electronics-team/systemc.git

I had a quick view on it. First issue (in my eyes) I've seen was a
missing tag of the imported version on the upstream branch so I'd need
to use pristine-tar manually to create the orig tarball.
git-buildpackage does the creation of the orig tarball automatically if
it found a tag based on the entry in the changelog file so I created the
tag by myself.

Unfortunately the package isn't Lintian error clean which would end in
an autoreject I guess.

> E: systemc source: missing-notice-file-for-apache-license NOTICE
> I: systemc source: testsuite-autopkgtest-missing
> I: libsystemc-doc: spelling-error-in-copyright Synopsys Synopsis
> I: libsystemc-doc: possible-documentation-but-no-doc-base-registration
> W: libsystemc: package-name-doesnt-match-sonames libsystemc-2.3.2
> I: libsystemc: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libsystemc-2.3.2.so modfied modified
> I: libsystemc: hardening-no-bindnow usr/lib/x86_64-linux-gnu/libsystemc-2.3.2.so
> I: libsystemc: spelling-error-in-copyright Synopsys Synopsis
> I: libsystemc-dev: spelling-error-in-copyright Synopsys Synopsis
> I: libsystemc-dev: extra-license-file usr/include/sysc/packages/boost/config/platform/bsd.hpp

There are some more minor issue that should be easily fixable like the
spelling error in the copyright file. Also the doc-base issue can be
solved by adding a sequencer file.

The last entry on the list is obviously a false positive that can get a
override, but looking at the file in detail you probably have missed
it's licensed under boost-1.0 like all other files in the folder too.
This will result by a rejected of the ftpmaster for the complete package
as the information in the copyright file is not complete.

I guess all the files and folders aren't really needed and could be
simply dropped while importing the source, if so you would need to add a
suffix '+ds' to the imported version. If not please expand the
information in the copyright file and talk to upstream to prevent the
future usage of embedded code copies.

The same needs to be checked for the qt code that is also embedded in
src/sysc/packages/qt/.

-- 
Regards
Carsten Schoenert

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-electronics-devel/attachments/20180707/1cc3d8a2/attachment.sig>