[Pkg-emacsen-addons] htmlize.el and elpa-muse/muse-el

[Nicholas D Steeves]

On Thu, Sep 01, 2016 at 10:20:49PM +0000, Sean Whitton wrote:
> Hello,
> 
> On Thu, Sep 01, 2016 at 12:13:35AM -0400, Nicholas D Steeves wrote:
> > Spwhitton and I were chatting about this on #debian-emacs last night.
> 
> It's 'Sean' ;)

Hi Sean!  :-)

> > I created the following quilt patch and tested it locally, but haven't
> > pushed it yet.  I've tested two versions of it, one with just (require
> > 'htmlize.el), and one that has both (require 'htmlize.el) and (provide
> > 'htmlize-hack), but not the obsolete version check.  Both avoid the
> > above block-quoted error.  What blows my mind is that function should
> > be skipped when the version check fails to find (equal htmlize-version
> > = "1.34")...
> 
> Looking at your quilt patch, it looks like this is a fix for a
> particular version of htmlize.  The problem is that we don't know
> whether later versions of htmlize fix the problem or not (maybe
> htmlize-hack.el was written when version 1.34 was the latest version but
> the fix was never merged upstream).
> 
> I think you need to test muse with your quilt patch and the latest
> htmlize and see if things are sane.  If not, you might just have to take
> out the htmlize support altogether, until muse gets updated (or you
> could write a patch to update muse to not need the hack, and submit it
> upstream and apply as a quilt patch).
> 
> > Does this mean that there is a bug in elpa that is triggered by
> > version checks?  Or was the installation/configurations previously
> > failing because the version check failed because htmlize wasn't
> > actually loadable?  I would expect that it would fail immediately at
> > (require 'htmlize) if htmlize cannot be found...
> 
> I don't see any bug in dh_elpa here.  Could you explain what you were
> expecting dh_elpa to do that it isn't doing?
> 
> -- 
> Sean Whitton

In #debian-emacs David found no problems installing to sid—no patch
needed, so I installed stretch/testing on an ancient laptop I keep
around as an emergency backup.  It pulled in htmlize from
emacs-goodies-el, and everything was fine.  If org-mode is already
installed, htmlize.el from goodies is used, presumably because
emacs-goodies alphabetically precedes org-mode.

In testing your experimental dh-elpa bpo with my experimental
elpa-muse bpo, I found that using the emacs24 bpo yielded a successful
configuration.

In light of this, when you backport dh-elpa for magit2 ;-), please
make it depend on a minimum version of emacs 24.5+1-6~bpo8+1.

Cheers!
Nicholas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-emacsen-addons/attachments/20160902/799e9d33/attachment.sig>