Bug#590333: update-exim4.conf.template getopt incorrect

Andreas Metzler ametzler at downhill.at.eu.org
Mon Jul 26 16:45:35 UTC 2010


On 2010-07-26 "Matthew W. S. Bell" <matthew at bells23.org.uk> wrote:
> Package: exim4-config
> Version: 4.72-1
> Severity: normal
> Tags: patch

> Hi,
> In update-exim4.conf.template, a : is omitted for the o (output option).

> Matthew W.S. Bell

> --- update-exim4.conf.template  2005-04-03 08:39:12.000000000 +0100
> +++ update-exim4.conf.template  2010-07-26 01:27:11.000000000 +0100
> @@ -20,8 +20,8 @@

>  ## Parse commandline
>  TEMP=$(getopt -n update-exim4.conf.template \
> -	-l nobackup,output:,help,run -- \
> -	+nohr "$@")
> +	-l nobackup,output:,help,run \
> +	-o +no:hr -- "$@")

>  if test "$?" != 0; then
>         echo "Terminating..." >&2

Is there a specific reason why you for switching getopt invocation
syntax instead of making this a one-line change?

-	+nohr "$@")
+	+no:hr "$@")

thanks, cu andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'





More information about the Pkg-exim4-maintainers mailing list