Bug#590333: update-exim4.conf.template getopt incorrect

[Matthew W. S. Bell]

On Mon, 2010-07-26 at 18:45 +0200, Andreas Metzler wrote:
> On 2010-07-26 "Matthew W. S. Bell" <matthew at bells23.org.uk> wrote:
> > Package: exim4-config
> > Version: 4.72-1
> > Severity: normal
> > Tags: patch
> 
> > Hi,
> > In update-exim4.conf.template, a : is omitted for the o (output option).
> 
> > Matthew W.S. Bell
> 
> > --- update-exim4.conf.template  2005-04-03 08:39:12.000000000 +0100
> > +++ update-exim4.conf.template  2010-07-26 01:27:11.000000000 +0100
> > @@ -20,8 +20,8 @@
> 
> >  ## Parse commandline
> >  TEMP=$(getopt -n update-exim4.conf.template \
> > -	-l nobackup,output:,help,run -- \
> > -	+nohr "$@")
> > +	-l nobackup,output:,help,run \
> > +	-o +no:hr -- "$@")
> 
> >  if test "$?" != 0; then
> >         echo "Terminating..." >&2
> 
> Is there a specific reason why you for switching getopt invocation
> syntax instead of making this a one-line change?

Yes. It was reached by shotgun programming.

Matthew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-exim4-maintainers/attachments/20100730/b5f8deba/attachment.pgp>