[pymvpa] request for review

Valentin Haenel valentin.haenel at gmx.de
Fri Apr 24 09:07:39 UTC 2009


Hi,

i am working with FIR betas. Thus i have 8 timebins for which i need to rerun
the searchlight. This should result in 8 accuracy maps, one for each timebin.

Although i could just iterate over datasets with the searchlight call, however
in that case the searchlight indexes would be recomputed for each timebin.

I modified the Searchlight to operate also on lists of datasets, whereby the
searchlight indexes are stored and used again for each timebin after the first
this works for my particular use case, and reduces the computing time somewhat.

I patched the code such that the API remains backward compatible, and existing
code should not break.

I do not know how else the Searchlight is used, so i am not sure if my
modifications break something, and unfortunately the unit tests are still
segfaulting on this end, and i'm not sure how to run only the unit test for the
Searchlight.

Also i ran the code through pylint, and it complained mainly about functions
prefixed with __.

I would also like to check that the datasets are of the same brain, not sure how
to do that though, maybe check equality of the masks?

Furthermore i think there is a bug on line 84, where it says FIXME, however if
this is the case i would probably send a separate patch for that.

Please have a look at the code.

cheers

V-



More information about the Pkg-ExpPsy-PyMVPA mailing list