[pymvpa] request for review OUPS WRONG PATCH

[Valentin Haenel]

* Michael Hanke <michael.hanke at gmail.com> [090424]:
> On Fri, Apr 24, 2009 at 11:14:41AM +0200, Valentin Haenel wrote:
> > er, i think i attached the wrong patch. fracking git commit --amend :-)
> > 
> > here, use this one instead.
> 
> It looks sane to me. I see the advantages of running multiple datasets
> for the same sphere setup at once. On the other hand this adds some
> magic that just applies to the searchlight measure -- not sure whether
> we want that kind of variability among the different measures. I'm not
> necessarily opposed to the change...

an alternative would be to equip Searchlight with an additional function which
explicitly takes a list of datasets, and this could possibly be extended to
other measures. 

> Did you do some comparison what you actually gain from moving the
> dataset loop inside of searchlight in comparison to a simple outer loop
> (in terms of speed)? I guess it could be quite a bit...

Yeah some timing experiments i ran took the total time for one subject from 2:40
to 2:00. So thats quite a bit. Of course thats all entirely dependent on the
local machines and my data.


What about the:

    # FIXME what if __center_ids is set, in that case the number of 
    # spheres should be len(self.__center_ids) 
    self.nspheres = dataset.nfeatures 
    self.sphere_count = 0

?

BTW: the debug output of my is now a bit broken, ;-( but i have the patch here
already :-) No sure how to send that upstream now.


V-