[Pkg-fglrx-devel] r678 - fglrx-driver/trunk/debian
Michael Gilbert
michael.s.gilbert at gmail.com
Sun Aug 7 00:28:45 UTC 2011
> On 2011-08-07 01:56, Michael Gilbert wrote:
>> I still don't see why this is needed. DEB_BUILD_ARCH is automatically
>> populated on the buildd's for example.
>
> Quoting from dpkg-architecture(1)
>
> The environment variables set by dpkg-architecture are passed to
> debian/rules as make variables (see make documentation). However,
> you should not rely on them, as this breaks manual invocation of the
> script. Instead, you should always initialize them using
> dpkg-architecture with the -q option.
>
> in r677:
> $ dpkg-architecture | grep _ARCH=
> DEB_BUILD_ARCH=amd64
> DEB_HOST_ARCH=amd64
> $ debian/rules debian/fglrx-driver.install
> sed -e s/_VERSION_/11-7/g -e s/_ARCH_/x86/g -e s/_XPIC_/xpic/g -e
> s/_LIB_/lib/g < debian/fglrx-driver.install.in > debian/fglrx-driver.install
>
> variable not initialized, manual invocation produces garbage
Well, that didn't exactly produce garbage. It produced the i386 build
by default, and I don't really see that as a problem. If someone
really wants amd64, they'll need to set the flag manually or use
something that automatically populates the dpkg-architecture flags.
>> Isn't a "build" var more
>> appropriate anyway vs the "host" var?
>
> dpkg-architecture(1), again:
>
> TERMS
> build machine
> The machine the package is built on.
> host machine
> The machine the package is built for.
OK, that clears it up the terminology. Thanks for the pointer.
So, my opinion is still that this isn't needed, but an s/BUILD/HOST/g
would be fine.
Best wishes,
Mike
More information about the Pkg-fglrx-devel
mailing list