[Pkg-fglrx-devel] r678 - fglrx-driver/trunk/debian

[Michael Gilbert]

>> On 2011-08-07 01:56, Michael Gilbert wrote:
>>> I still don't see why this is needed. DEB_BUILD_ARCH is automatically
>>> populated on the buildd's for example.
>>
>> Quoting from dpkg-architecture(1)
>>
>>  The  environment variables set by dpkg-architecture are passed to
>>  debian/rules as make variables (see make documentation). However,
>>  you should not rely on them, as this breaks manual invocation of the
>>  script. Instead, you should always initialize them using
>>  dpkg-architecture with the -q option.
>>
>> in r677:
>> $ dpkg-architecture | grep _ARCH=
>> DEB_BUILD_ARCH=amd64
>> DEB_HOST_ARCH=amd64
>> $ debian/rules debian/fglrx-driver.install
>> sed -e s/_VERSION_/11-7/g -e s/_ARCH_/x86/g -e s/_XPIC_/xpic/g -e
>> s/_LIB_/lib/g < debian/fglrx-driver.install.in > debian/fglrx-driver.install
>>
>> variable not initialized, manual invocation produces garbage
>
> Well, that didn't exactly produce garbage.  It produced the i386 build
> by default, and I don't really see that as a problem.  If someone
> really wants amd64, they'll need to set the flag manually or use
> something that automatically populates the dpkg-architecture flags.

I take that back.  This would build an amd64 package with i386 binaries,
which is wrong.  So, I after this realization, I concur with your
approach :)

Best wishes,
Mike