[Pkg-fonts-devel] Request for review/sponsorship. ITP #511036

Christian Perrier bubulle at debian.org
Tue Dec 1 18:09:51 UTC 2009


Quoting simon at ochsenreither.de (simon at ochsenreither.de):
> Hi,
> 
> could someone review my package?
> 
> It is here:
> http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=ttf-droid
> 
> It is already lintian clean.
> 
> I just have some minor specific questions:
> 
> a) Regarding the drop of defoma: I have dropped the hint file, the
> dependency and the rule, is that correct? It looks like the fonts
> are recognized correctly without the hint file, are there any
> additional steps necessary?

You need to take care of purging defoma's cache and also cleanly
remove the hints file. See atatched preinst script.

> b) Source format: Is there anything I have to do?

1) Add debian/source/format as attached.
2) Drop any dependency on quilt if you were using it (very unlikely
for fonts)

> c) What are the dependencies/suggestions in control? I have seen
> packages which suggest x-ttcidfont-conf | fontoconfig, others which
> don't suggest anything, etc.

This is not yet standardized..:-)

> d) Is the name correct? I didn't find a policy on how the package
> should be named, and followed the pattern ttf-<fontname>. Some
> packages have the pattern ttf-<foundry>-<fontname>, some have other
> names ... any suggestions?
> 

This is not yet standardized but ttf-<foundry>-<fontname> seems to be
a better choice when <foundry> is clear to identify.


-------------- next part --------------
#!/bin/sh

set -e

VERSION=2.51-4
PKG=ttf-sil-ezra
FILE=/etc/defoma/hints/${PKG}.hints

# Remove a no-longer used conffile
rm_conffile() {
    local PKGNAME="$1"
    local CONFFILE="$2"
    [ -e "$CONFFILE" ] || return 0

    local md5sum="$(md5sum $CONFFILE | sed -e 's/ .*//')"
    local old_md5sum="$(dpkg-query -W -f='${Conffiles}' $PKGNAME | \
            sed -n -e "\' $CONFFILE ' { s/ obsolete$//; s/.* //; p }")"
    if [ "$md5sum" != "$old_md5sum" ]; then
        echo "Obsolete conffile $CONFFILE has been modified by you."
        echo "Saving as $CONFFILE.dpkg-bak ..."
        mv -f "$CONFFILE" "$CONFFILE".dpkg-bak
    else
        echo "Removing obsolete conffile $CONFFILE ..."
        rm -f "$CONFFILE"
    fi
}

case "$1" in
install|upgrade)
    if dpkg --compare-versions "$2" lt-nl "$VERSION"; then
	if [ -f $FILE ]; then
        	if [ -x /usr/bin/defoma-font ]; then
			defoma-font purge-all $FILE || true
		fi
	fi
	rm_conffile $PKG $FILE
    fi
esac

#DEBHELPER#
-------------- next part --------------
3.0 (quilt)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/attachments/20091201/222113ff/attachment.pgp>


More information about the Pkg-fonts-devel mailing list