[Pkg-fonts-devel] Upload of newer fonts-android and fonts-roboto

Fabian Greffrath fabian at debian.org
Thu Dec 10 06:09:25 UTC 2015

Dear Vasudev,

the time spent waiting for one of us lazy cows to review your changes
could just as well have been used for uploading the packages and
awaiting incoming bug reports. ;)

So, I had a quick glance over your changes:

1) fonts-android
a) I would install DroidSansFallback.ttf into its own directory
directly using the debian/*.install file instead of installing it into
its previous location and then moving it around in debian/rules. The
debian/*.dirs file could then get removed, too. Also, README.Debian
speaks of _two_ offending files that are moved?
b) There is no hint anymore in the form of a command line that shows
how to reproduce the orig tarball with GIT (and I fail to understand
the debian/watch file).

2) fonts-roboto
So, the fonts are now built from source? Nice!
a) I would simplify debian/copyright and condense all "© Google" stuff
into one paragraph. Why is debian/* licensed GPL-3+?!
b) Oh, CDBS, I see. Good luck with it.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/attachments/20151210/4d16a673/attachment.sig>

More information about the Pkg-fonts-devel mailing list