[Pkg-fonts-devel] Upload of newer fonts-android and fonts-roboto
vasudev at copyninja.info
Thu Dec 10 11:04:03 UTC 2015
Fabian Greffrath <fabian at debian.org> writes:
> Dear Vasudev,
> the time spent waiting for one of us lazy cows to review your changes
> could just as well have been used for uploading the packages and
> awaiting incoming bug reports. ;)
I'm no DD and I don't have upload rights no those packages ;-).
> So, I had a quick glance over your changes:
> 1) fonts-android
> a) I would install DroidSansFallback.ttf into its own directory
> directly using the debian/*.install file instead of installing it into
> its previous location and then moving it around in debian/rules. The
> debian/*.dirs file could then get removed, too.
OK yes that is more straight forward. I just kept the old cruft as is. I
will update it.
>Also, README.Debian speaks of _two_ offending files that are moved?
Umm I thought I updated README.Debian, I will have a look.
> b) There is no hint anymore in the form of a command line that shows
> how to reproduce the orig tarball with GIT (and I fail to understand
> the debian/watch file).
I droped the create_orig_source as its no longer used to create orig
tarball. debian/watch is used to do that and yeah even I don't
completely understand it. It was introduced by Yamane san :-).
> 2) fonts-roboto
> So, the fonts are now built from source? Nice!
No not yet. I don't think all required tools are in Debian yet. Yamane
san did package some of the tools but I'm not sure if they hit archive
> a) I would simplify debian/copyright and condense all "© Google" stuff
> into one paragraph.
Ah yes will do that.
> Why is debian/* licensed GPL-3+?!
Just my preferred license. Is it bad to make it GPL-3+?.
> b) Oh, CDBS, I see. Good luck with it.
More information about the Pkg-fonts-devel