[Pkg-freeipa-devel] Bug#1136462: 389-ds-base uses pidof but does not depend on procps

[Gioele Barabucci]

Source: 389-ds-base
Version: 3.1.2+vendor1-2
Usertags: pidof-without-procps

Dear maintainer(s) of 389-ds-base,

it appears that 389-ds-base uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of 389-ds-base
  that use `pidof` at runtime;
* via the `Build-Depends:` field of 389-ds-base, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of 389-ds-base, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that 389-ds-base uses `pidof` due to the following
code snippets:

```
path: 389-ds-base_3.1.2+dfsg1-1/dirsrvtests/tests/suites/logging/security_basic_test.py
    # Get ldapmodify pid
    result = subprocess.check_output(['pidof','ldapmodify'])
    ldapmodify_pid = ensure_str(result)


path: 389-ds-base_3.1.2+dfsg1-1/dirsrvtests/tests/suites/basic/basic_test.py
    dse_file = topology_st.standalone.confdir + '/dse.ldif'
    pid = check_output(['pidof', '-s', 'ns-slapd']).strip()
    # We can't guarantee we have access to sudo in any environment ... Either
    # run py.test with sudo, or as the same user as the dirsrv.
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci