[Pkg-freeipa-devel] Bug#1136503: freeipa uses pidof but does not depend on procps

[Gioele Barabucci]

Source: freeipa
Version: 4.13.1-1
Usertags: pidof-without-procps

Dear maintainer(s) of freeipa,

it appears that freeipa uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of freeipa
  that use `pidof` at runtime;
* via the `Build-Depends:` field of freeipa, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of freeipa, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that freeipa uses `pidof` due to the following
code snippets:

```
path: freeipa_4.13.1-1/ipatests/test_integration/test_trust.py
        client = self.clients[0]
        tasks.backup_file(self.master, paths.SSSD_CONF)
        res = self.master.run_command(['pidof', 'sssd_be'])
        pid = res.stdout_text.strip()
        test_id = 'id testuser@%s' % self.ad_domain


path: freeipa_4.13.1-1/ipatests/test_integration/test_commands.py
        def count_pipes():
            res = self.master.run_command(['pidof', 'sssd_ssh'])
            pid = res.stdout_text.strip()
            proc_path = '/proc/{}/fd'.format(pid)
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci