Bug#443822: I've found a fix (for: hex-a-hop: Got bt from a segfault :D)

Jens Seidel jensseidel at users.sf.net
Mon Dec 17 14:09:33 UTC 2007


On Mon, Dec 17, 2007 at 01:04:40PM +0100, Roland Clobus wrote:
> ---- Jens Seidel <jensseidel at users.sf.net> wrote: 
> > > --- hex_puzzzle.cpp	2007-12-16 13:19:47.000000000 +0100
> > > +++ hex_puzzle.fixed.cpp	2007-12-16 13:19:05.000000000 +0100
> > > @@ -602,6 +602,9 @@
> > >  		{
> > >  			while (numStages > 0 && time[numStages-1] >= t)
> > >  				numStages--;
> > > +			if (currentStage > 0 && currentStage >= numStages) {
> > > +				currentStage = numStages - 1;
> > > +			}
> > 
> > Is this also save if numStages==0? I will try to check it during the
> > next weekend and play some levels.
> 
> You are right, currentStage should also be limited to zero.
> So another line from UpdateCurrent needs to be copied here too.

OK, did so.

The problem is that I have no slight idea what these variables mean. If
you want feel free to send a patch which adds a few (doxygen) style
comments (the original author no longer supports it, I'm now more or
less the current upstream but this doesn't mean that I fully understand
the old code :-) ...).

Jens





More information about the Pkg-games-devel mailing list