Bug#555964: wesnoth: Distinguish Random and "Choosing leader"; don't start game with the latter

[Josh Triplett]

On Sat, Nov 14, 2009 at 12:23:26AM +0100, Gerfried Fuchs wrote:
> severity 555964 wishlist
> thanks
> 
> * Josh Triplett <josh at joshtriplett.org> [2009-11-12 23:23:17 CET]:
> > When a player joins a multiplayer game, their chosen leader shows up as
> > "Random" until they finish picking a leader.  Sometimes, the game host
> > will start the game before checking if people have finished picking a
> > leader, and thus the players still choosing a leader will end up with a
> > random leader.  Wesnoth should distinguish between "Random" and
> > "Choosing leader", and should not allow starting the game with players
> > still choosing a leader.
> 
>  When I understand you correctly you want to have the option removed
> that people want to actively *not* choose a specific leader but indeed
> *want* a random leader?
> 
>  I'm not sure wether that really can be considered a bug, especially
> since it has explicitly written "random" there, and I don't think that
> upstream would consider removing having that option is a good idea. I'll
> leave it open as wishlist until I've received feedback on the idea from
> upstream, though.

No, not at all what I meant.  When choosing a leader, the player can
explicitly choose "Random", no problem.  The bug comes up when the
player hasn't *finished* choosing a leader; at that point, from the
perspective of the host (and other players who have finished choosing a
leader), the player's leader still shows up as "Random" rather than
something like "Choosing a leader", and the host can proceed at that
point without waiting for the player to finish choosing.  If the host
does so, then the player will get to finish choosing a leader, at which
point they get thrown directly into the game with a random leader (*not*
the one they chose).

So, not complaining at all about the ability to choose "Random";
complaining about a situation that can end up giving a player "Random"
when they didn't want that.

- Josh Triplett