Bug#555964: wesnoth: Distinguish Random and "Choosing leader"; don't start game with the latter

[Mark de Wever]

Hi Rhonda, Josh,

On Fri, Nov 13, 2009 at 04:11:29PM -0800, Josh Triplett wrote:
> On Sat, Nov 14, 2009 at 12:23:26AM +0100, Gerfried Fuchs wrote:
> > * Josh Triplett <josh at joshtriplett.org> [2009-11-12 23:23:17 CET]:
> > > When a player joins a multiplayer game, their chosen leader shows up as
> > > "Random" until they finish picking a leader.  Sometimes, the game host
> > > will start the game before checking if people have finished picking a
> > > leader, and thus the players still choosing a leader will end up with a
> > > random leader.  Wesnoth should distinguish between "Random" and
> > > "Choosing leader", and should not allow starting the game with players
> > > still choosing a leader.
> > 
> >  When I understand you correctly you want to have the option removed
> > that people want to actively *not* choose a specific leader but indeed
> > *want* a random leader?
> > 
> >  I'm not sure wether that really can be considered a bug, especially
> > since it has explicitly written "random" there, and I don't think that
> > upstream would consider removing having that option is a good idea. I'll
> > leave it open as wishlist until I've received feedback on the idea from
> > upstream, though.
> 
> No, not at all what I meant.  When choosing a leader, the player can
> explicitly choose "Random", no problem.  The bug comes up when the
> player hasn't *finished* choosing a leader; at that point, from the
> perspective of the host (and other players who have finished choosing a
> leader), the player's leader still shows up as "Random" rather than
> something like "Choosing a leader", and the host can proceed at that
> point without waiting for the player to finish choosing.  If the host
> does so, then the player will get to finish choosing a leader, at which
> point they get thrown directly into the game with a random leader (*not*
> the one they chose).

This is indeed the problem, the host doesn't know whether or not the
player is selecting a leader or already selected a random leader. If the
host starts the game while the player is still selecting the game is
started with a random leader for that player. What the player selects at
that point is ignored since the game has already been started.

So it's a valid bug, that's why I forwarded it upstream.

-- 
Regards,
Mark de Wever
(Wesnoth developer)