RFS: visualboyadvance/1.8.0.dfsg-2

[Etienne Millon]

Hi Vincent,

Thanks for the review.

* Vincent Legout <vincent at legout.info> [130513 22:39]:
> It builds fine but it fails to build twice in a row because some files
> in po/ are updated during the build. I'm not sure about the best fix,
> but I think adding a patch with the updated version of the .po files and
> deleting vba.pot in the clean target could be ok. Or the .po files must
> not be updated during the build.
>
> Can you please fix this and I'll upload ?

Ah, good call. I discovered that it's now possible to pass --twice to
pbuilder through --git-pbuilder-options, I'll make sure to test with
that in the future.

I disabled the recreation of vba.pot through the xgettext, because the
tarball embeds an up-to-date copy (commit 58ae0d). I tried to
regenerate the .po files at build time, but this fails to build twice
in a row because the timestamps change.

> And 2 minor comments:
> 
> - Instead of calling aclocal, autoconf and automake in
>   dh_auto_configure, do you know dh-autoreconf which calls autoreconf
>   and then cleans everything ?

I tried but unfortunately this does not work, because it recreates a
lot of files (INSTALL, etc) and dh_autoreconf_clean deletes for
example mkinstalldirs. It should be possible to save these files and
restore them (writing a lot of logic), or repack the tarball, but just
calling the autotools manually is the least ugly IMHO.

> - Can you please follow DEP3 in the new patch 13_debugger_format.patch ?

Oops, I switch my workflow from gbp-pq to using quilt directly and
didn't pick this habit. Fixed (0182f1).

I also moved the clean targets do debian/clean (ca35ff).

I repushed the package to alioth and re-uploaded the .dsc to mentors
at the same URL.

Thanks again!

-- 
Etienne Millon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20130515/7a63465b/attachment.pgp>