Bug#737363: higan: crashes when importing or loading unheadered NES ROM

Michael Gold michael at bitplane.org
Sun Feb 2 14:25:23 UTC 2014


On Sun, Feb 02, 2014 at 13:24:30 +0100, Tobias Hansen wrote:
> Hi Michael,
> 
> thanks for all those nice bug reports! I'm quite sure that higan can
> only import NES games with iNES headers because I saw byuu say they
> contain crucial information that is needed to generate the manifests. If
> you can also provide a patch adding a check for iNES headers you are my
> favourite bug submitter. ;)

ananke/heuristics/famicom.hpp already has a check, but
ananke/famicom.cpp doesn't check for info.markup=="".  I'll see if I can
propagate a failure from there.

There's an interesting comment at the bottom of that file:
//this currently cannot work:
//game folders discard iNES header required for heuristic detection
//a games database of all commercial Famicom software will be required
string Ananke::syncFamicom(const string &pathname) {
  return "";
}

...and I see there's already a Super Famicom database.

-- Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140202/f955add3/attachment.sig>


More information about the Pkg-games-devel mailing list