Bug#737363: higan: crashes when importing or loading unheadered NES ROM

Thu Feb 6 04:35:24 UTC 2014

tags 737363 patch
stop

On Sun, Feb 02, 2014 at 13:24:30 +0100, Tobias Hansen wrote:
> Hi Michael,
> 
> thanks for all those nice bug reports! I'm quite sure that higan can
> only import NES games with iNES headers because I saw byuu say they
> contain crucial information that is needed to generate the manifests. If
> you can also provide a patch adding a check for iNES headers you are my
> favourite bug submitter. ;)

Here are some patches.  The first shows an error if there's no header.
But that's annoying, so the others add database support.  The DB has
everything from the 20140124-114835 no-intro set, except for those noted
below.  Most of the information was autogenerated by higan so it's not
as detailed or clean as the SFC DB.

-- Michael

missing rom ( name "Arkanoid II (Japan).nes" size 196608 crc 0F141525 md5 83A6E0D589D5C9490F757B5A115E8C06 sha1 627D4F20667EDED6F26A379C8477669348F3ECAB )
missing rom ( name "Batman - Return of the Joker (USA) (Beta).nes" size 393216 crc 29DD37F4 md5 E47CF9891071441D96EC59A32E1BF93E sha1 7F6B6D58772163BF8EFD4B91CB2375B7267D52E2 )
missing rom ( name "Best Keiba - Derby Stallion (Japan).nes" size 262144 crc A1A33B85 md5 EC1D2136C9A19AAE8174B237A8347CD1 sha1 87FEFD2FF030DC353BDCE2670D082158208CB307 )
missing rom ( name "Block Out (USA) (Proto).nes" size 131072 crc CF992E34 md5 AE3629D17FEE770EE5E2D9AFA7B683C0 sha1 2500B5492ECE1CAFB97881C5A384B0768313BF98 )
missing rom ( name "Championship Rally (Europe).nes" size 262144 crc C076D66F md5 8FEC068ADEABEC6A5DB2E07564EC2F19 sha1 017A692EF7D140565CC0827629BB16FA82E6FD7C )
missing rom ( name "David Crane's A Boy and His Blob - Trouble on Blobolonia (Europe) (Rev A).nes" size 262144 crc 8ECBC577 md5 5BC9D55333A5E77B54144A22539B67A9 sha1 04E6319370D20DD452CD10BACC026375E0F02E64 )
missing rom ( name "Dino-Hockey (USA) (Proto).nes" size 262144 crc EAB002AE md5 B73CB730493120E01924970DBC697C3D sha1 8E4076B0E12A3E9D0E489CBD25E97B227B7A66FC )
missing rom ( name "Dr. Mario (USA) (Beta).nes" size 65536 crc C49FCAB4 md5 EACEF8AA54C1762CC83AB1643E70E52C sha1 9BB56411F6EFA79FAC3D9CDBB3EF6EBF132E7FEE )
missing rom ( name "Famicom Wars (Japan) (Rev 0B).nes" size 196608 crc 9B547E05 md5 922F4F86C8719D1CEB9B7773600348AC sha1 882E0017099CC5784F3D3EFA66FAB4C38F83EC46 )
missing rom ( name "Family BASIC (Japan) (v2.1a).nes" size 40960 crc 895037BC md5 3C16A795A37046302CB0738282247567 sha1 8E90D9A6A6090307A7E408D1C1704D09BA8F94FC )
missing rom ( name "Field Combat (Japan).nes" size 24576 crc 1B45A73E md5 8CDD15B58199C088FD73D05BFAA20DB4 sha1 310B8C4A406B0CEB68C38E51FD0DBDFFE961A878 )
missing rom ( name "Futebol (Brazil) (Unl).nes" size 98304 crc 22F8E680 md5 63F559518DFA8D57621CC6BB0D87A928 sha1 240C3DE46DD37B89F8594E6BC4C4AC49874A4E67 )
missing rom ( name "Galaxian (Japan) (Rev A).nes" size 16384 crc 76A6A813 md5 7EA72482234AC1B3754153A559213367 sha1 0FE9120FD5ADC2790B0B9E8FADD136F9C66A709F )
missing rom ( name "Galaxian (Japan).nes" size 16384 crc 084F61CD md5 01C1F123F436943527F50EB585025B99 sha1 44BC6C4E8B3F6C635281B4C05382E8F316D8269E )
missing rom ( name "Game Master Kid (Unknown) (Proto) (Unl).bin" size 16384 crc 8A247477 md5 4C5B210A3D960BF48621C54DED5A2F75 sha1 DC7A75C433622E4E8A5600D5297DB267F101E20B )
missing rom ( name "Game Master Kid (Unknown) (Proto) (RAM) (Unl).bin" size 2048 crc AA416453 md5 2574A379BF7C2CB0A6AE096A165D7EDF sha1 B0A8BD85C22F486A012331AE873F87DBD855F016 )
missing rom ( name "Hard Drivin' (USA) (Proto) (Unl).nes" size 393216 crc 39AB0FC7 md5 37DD9403D0D3AD7E5305AF7D6E9A8159 sha1 90A58E6EA976B6C73B02146D41E623343836BDCA )
missing rom ( name "Hidden Chinese Chess - An Qi (Asia) (NTSC) (Unl).nes" size 24576 crc 961ADCA7 md5 2B5010407BE85468E2F885E040D9C4F1 sha1 7CE0A6D1C62EDFD4D218CF7657E01F02706AA6FC )
missing rom ( name "Igo - Kyuu Roban Taikyoku (Japan).nes" size 49152 crc 9B208AB1 md5 B694F7A85C7C3C91D44517BE009827E9 sha1 5B26C00AD2CD2DB81783AB039B2142E7B0A784D8 )
missing rom ( name "International Cricket (Australia).nes" size 262144 crc A66D5150 md5 063E3811B7B7703BC97393535BE24CBC sha1 73396BA69AA122D64DED6F211F3548242DFDF229 )
missing rom ( name "International Cricket (Australia) (Beta).nes" size 262144 crc 99C88648 md5 97AA395A9C318D75B33EA11BBAA2533D sha1 8861C25D42E6BC24A8E746F286B111B242853459 )
missing rom ( name "King Neptune's Adventure (USA) (Unl).nes" size 98304 crc CB53C523 md5 C0DFE24DEDEB3C704A51D3688A2E161D sha1 F5C62A5AC771C42D0F64A46D4A70D283EEEF58EB )
missing rom ( name "King Neptune's Adventure (USA) (Beta) (Unl).nes" size 131072 crc 4BC75F16 md5 AFC41E2419125768F1BF7CEADF5A3DB5 sha1 C0E3BD39A95D9BFB9C1D2A6932D99D618389D087 )
missing rom ( name "Micro Machines (Europe) (Unl).nes" size 262144 crc DB1FD64E md5 544D3812AC8510C919552B8AE3BA32F3 sha1 B093A65CA9E6006AC9D6BE2834DD8ADB03DD33AC )
missing rom ( name "Mighty Bomb Jack (Europe).nes" size 65536 crc 842A3FD9 md5 337422E3F827763CD03B59CABA401C36 sha1 FD45A6F9710258CAA30E42B0EF792D5779610260 )
missing rom ( name "Nobunaga no Yabou - Sengoku Gunyuu Den (Japan) (Rev A).nes" size 393216 crc F9B4240F md5 369BB5296FDBE5C2F06594071EF83F12 sha1 7BE3DFEBBBAE2BE4D382A81806DAB8F7F6712421 )
missing rom ( name "Othello (Australia) (Unl).nes" size 24576 crc 9C4589E3 md5 F28C6225095600B6B401469B0796CBF1 sha1 C10C526F26273C4A1E180B968665910B74C78B86 )
missing rom ( name "Pac-Man (Japan) (En) (Rev B).nes" size 24576 crc 2C7D68F3 md5 10A12B5840A13E8F3A61885C44BF3B8D sha1 BF49E53C6DA49DDF0BF947DD82140573AEB59103 )
missing rom ( name "Pinball Quest (Australia).nes" size 262144 crc 9F119033 md5 737BE18046DD10DFFE5B0E3AA7E32E0B sha1 D1BA76E93F14E66D98543EE1599475DD0E79A4A4 )
missing rom ( name "Prince of Persia (Spain).nes" size 131072 crc 4B1ED62E md5 EE517E870585E3610F5416F70A9D4607 sha1 3F097632E2387FBC26D2F808438EA544CEBE3D95 )
missing rom ( name "Sidewinder (Australia) (Unl).nes" size 32768 crc F5350410 md5 240302AF153103E9136269933D696DAF sha1 B1CC3ED04C610BE18742A3FD78A8F27A597F8549 )
missing rom ( name "Star Force (USA) (Beta).nes" size 65536 crc E81C71E9 md5 06834B3DC9F2065D140FE531098FDBAA sha1 3256127D9069DA4A94DB51DAB3DF931A9AFC6048 )
missing rom ( name "Tecmo Super Bowl (USA) (Beta).nes" size 393216 crc DB2D4F9D md5 9DF6D43E1DE330744DEB4A33CDBE5384 sha1 ACD4EBAC21DC04D7C8BD8A108EA4630B98038D00 )
missing rom ( name "Tetris (Bulletproof) (Japan).nes" size 49152 crc 0115EAF0 md5 47BBDA794CD043A7D6C650B31E348A98 sha1 2F12DE06F8F37101EAB791A3B7F51DFD475E0AF6 )
missing rom ( name "Virus (USA) (Beta) (1989).nes" size 40960 crc A9068D17 md5 9D7EECAA5731CED18F6AD9B6591A4411 sha1 4E95BE231674603BD106443E4AE581C87C00C867 )
missing rom ( name "Virus (USA) (Beta) (1990-02-02).nes" size 49152 crc 5EDEC8CD md5 0DA7C7EA9A12C80A92475E2117FEBEBF sha1 BA0429D47E0C0E0E83AFC987CA65ECC0FF809935 )
missing rom ( name "War on Wheels (USA) (Proto).nes" size 393216 crc 1675A6C1 md5 867908545370F25CBF420EE99C5417B3 sha1 2DB0FE8EE1AAFDB6953E4EB813A05B380B503AFE )
missing rom ( name "Yie Ar Kung-Fu (Japan) (Rev 1.2).nes" size 24576 crc 8BAA5FF2 md5 E035B66DF685B4C5A59D66E4BC491B3A sha1 7FB74587BE559B531C28F06CBE5FDD692711822C )
missing rom ( name "Yie Ar Kung-Fu (Japan) (Rev 1.4).nes" size 24576 crc 86CEFC12 md5 3C811B8B45949925CB02CC90BEFBFA35 sha1 55D6146D7CDDB4CA9BD368DCACD5A855999C1017 )
missing rom ( name "Yoshi (USA).nes" size 163840 crc E7EAD93B md5 7475CB5F648D86DA02D3F6E4197C974C sha1 4E48695ED4EF4DB19FBB3806D25397C371A479CD )
-------------- next part --------------
A non-text attachment was scrubbed...
Name: higan-fc-heuristic-error.diff
Type: text/x-diff
Size: 963 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140205/f11acfa6/attachment-0002.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: higan-fc-db-support.diff
Type: text/x-diff
Size: 3910 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140205/f11acfa6/attachment-0003.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: higan-fc-db-data.diff.bz2
Type: application/octet-stream
Size: 184329 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140205/f11acfa6/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140205/f11acfa6/attachment-0001.sig>