Bug#747274: slashem: various bugs due to LINUX not being defined

[Matt Day]

Package: slashem
Version: 0.0.7E7F3-6
Severity: important
Tags: patch

Dear Maintainer,

I upgraded slashem from 0.0.7E7F3-3 to 0.0.7E7F3-6 and discovered the
game would no longer find my saved-game file. I investigated and found it
trying to use a truncated saved-game filename, and that the truncation
was being performed by the regularize() function in sys/unix/unixunix.c,
because LINUX is not getting #defined as it should.

Turns out this is due to a typo in debian/patches/slashem-debian.patch:
    -/* #define LINUX */
    +#if defined(LINUX)
    +#define LINUX
    +#endif

Obviously the ! operator is missing. See the attached patch.

The slashem source code checks the LINUX define in a few places to
customize its behavior, so I expect there are a few other weird bugs.
With this patch, slashem was able to find my save file once again.

Thanks,
Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20140506/5e269202/attachment.html>
-------------- next part --------------
--- debian/patches/slashem-debian.patch-broken	2012-05-18 22:32:45.000000000 -0600
+++ debian/patches/slashem-debian.patch	2014-05-06 18:21:51.379813507 -0600
@@ -176,7 +176,7 @@
  			/* e.g. Suns sharing a playground through NFS */
  /* #define SUNOS4 */	/* SunOS 4.x */
 -/* #define LINUX */	/* Another Unix clone */
-+#if defined(LINUX)
++#if !defined(LINUX)
 +#define LINUX   	/* Another Unix clone */
 +#endif
  /* #define CYGWIN32 */	/* Unix on Win32 -- use with case sensitive defines */