Bug#745081: game-data-packager: add support for full versions of wolf3d and spear of destiny

[Simon McVittie]

On 17/01/15 15:29, Alexandre Detiste wrote:
>>> - opt. Suggests:   (but a full package would allways automaticaly
>>> recommends it's expansions)
> 
> I see now we can't process that automaticaly if a game is split in different
> yaml files like Doom.

Er, Doom isn't split into different YAML files? Doom, Doom 2 and the two
modules of Final Doom are (mechanically) entirely independent games.

> And for rott we have two 'type: full', so maybe
> adding an heuristic to pick the first, but that get complex.

Yes, this is more problematic.

>>     demo_for: quake2-full-data
>>     expansion_for: quake2-full-data
> 
> At first I thought that would be an extensive change,
> but in the end we only need to change _populate_package()
> and derive a package.type value from the optional presence of demo_for  & expansion_for .

I was thinking more of changing the package.type tests to look at
package.demo_for and package.expansion_for; but this approach could work
too.

> I can do it + fix all yaml files if you want.

Yes please; I'm concentrating on trying to get the last few games into
Python/YAML (CD-ripping for Quake and Quake II, compiling game modules
for Quake II, and lots of misc processing for lgeneral).

>> In particular, naming the developer/publisher doesn't really seem
>> important here.
> It's still in the *.copyright files

Indeed.

>>> This needs *relicensing* of those bits too.
>> Yeah, not worth it. Let's leave the YAML GPL-2 unless previous authors
>> want to make it more permissive.
> You mean "GPL-2+" ?

I mean GPL-2 - anything that is already GPL-2 (so, anything copied into
the YAML from existing files) cannot be made a more permissive license
than GPL-2 without its copyright holder's permission, and GPL-2+ is more
permissive than GPL-2.

    S