Bug#745081: game-data-packager: add support for full versions of wolf3d and spear of destiny

[Alexandre Detiste]

> > - opt. Suggests:   (but a full package would allways automaticaly
> > recommends it's expansions)

I see now we can't process that automaticaly if a game is split in different
yaml files like Doom. And for rott we have two 'type: full', so maybe
adding an heuristic to pick the first, but that get complex.

> 
> Good idea. We might have to change from
> 
>     type: demo
>     type: expansion
> 
> to
> 
>     demo_for: quake2-full-data
>     expansion_for: quake2-full-data
> 
> to achieve that, but I've been considering doing that anyway.

This is better.

At first I thought that would be an extensive change,
but in the end we only need to change _populate_package()
and derive a package.type value from the optional presence of demo_for  & expansion_for .

if 'demo_for' in d:
     setattr(package, 'type', 'demo')
if 'expansion_for' in d:
     setattr(package, 'type', 'expansion')

I can do it + fix all yaml files if you want.

> In particular, naming the developer/publisher doesn't really seem
> important here.
It's still in the *.copyright files

> > This needs *relicensing* of those bits too.
> 
> Yeah, not worth it. Let's leave the YAML GPL-2 unless previous authors
> want to make it more permissive.
You mean "GPL-2+" ?

Alexandre