Bug#916303: steam: installs to ~/.steam, which is not as intended by upstream

[Simon McVittie]

On Fri, 18 Jan 2019 at 11:25:12 +0000, Simon McVittie wrote:
> On Fri, 18 Jan 2019 at 00:31:33 -0500, Michael Gilbert wrote:
> > The two viable solutions I see are.  One, use a debian specific dir in
> > ~/.steam
> 
> This would be a straightforward
> change after fixing #919467: the "# This is a new installation" code path
> currently says STEAMDIR="$HOME/.steam", and the patch on #916303 changes
> it to STEAMDIR="$XDG_DATA_HOME/.steam", but instead we could change it
> to STEAMDIR="$HOME/.steam/debian-installation-path" or something like
> that.

I'm going to upload this to experimental shortly, fixing both #919467 and
#916303. The freeze is soon, so I intend to follow up with an upload to
unstable later this week.

The new behaviour is:

- In new installations, $STEAMDIR (the equivalent of C:\Program Files\Steam)
  is ~/.steam/debian-installation, with ~/.steam/steam and ~/.steam/root
  created by Steam as symlinks to that directory, i.e. #916303 is fixed

- If an existing installation had ~/.steam/steam or ~/.steam/root as a
  symlink to anywhere else (in particular Valve's $XDG_DATA_HOME/Steam),
  that will continue to be used as the $STEAMDIR, i.e. #919467 is fixed

- If an existing installation had ~/.steam as the $STEAMDIR (past Debian
  behaviour, detected by ~/.steam/root being a symlink to ~/.steam or by
  ~/.steam/steam being a non-symlink directory) then we keep using it

I hope that meets with your approval.

Thanks,
    smcv